Skip to content

Conversation

@val-2
Copy link
Contributor

@val-2 val-2 commented Nov 19, 2025

Closes #4115 .
Created a new todayTimeOrDateTime function in locale.ts that takes a timestamp and returns only the formatted time if it’s from the current day, otherwise it returns the formatted date and time. This function is now used to format message timestamps for both user and agent.

@rekram1-node
Copy link
Collaborator

@val-2 looks great, can we make it toggle-able in the ctrl+p command palette?

@val-2
Copy link
Contributor Author

val-2 commented Nov 20, 2025

Which part do you mean? Like the finish time for the agent, the message date if not current day or both?

@rekram1-node
Copy link
Collaborator

Make them both configurable under a single setting like toggle timestamp or something (both on or both off)

Also our designer had this feedback:

Do we need the seconds? I get that it's accurate, but it's not often you see seconds.
For the username can we make that dull text too? I know it's nice to differentiate with the timestamp, but it's competing with the user message and the name is secondary info.
Also I think we can drop the parenthesis - we should try to avoid them if we can. I'd suggest adding a middot between the name and the timestamp.

Screenshot 2025-11-20 at 3 06 10 PM

Here is a mockup he made

What do you think?

@val-2
Copy link
Contributor Author

val-2 commented Nov 20, 2025

Looks great, I can implement the design.
As for the option name, do you think a name like "Toggle detailed timestamps" is good or something else?
Also how should dates be shown in the new design? Something like this?
Username · 10:10 AM | 11/20/2025
Of course formatted in the user locale

@rekram1-node
Copy link
Collaborator

rekram1-node commented Nov 20, 2025

maybe just: "Toggle timestamps"?

I think that looks good, may look better w/ double dot tho?

Username · 10:10 AM · 11/20/2025

@val-2
Copy link
Contributor Author

val-2 commented Nov 20, 2025

Okay got it, thanks for the quick feedback!
I will modify the PR with your suggestions

@rekram1-node
Copy link
Collaborator

sweet!

@val-2
Copy link
Contributor Author

val-2 commented Nov 21, 2025

I made the suggested changes, a few notes:

  1. I used kv to save the setting so that it gets retained after a restart of the program. The possible values are 2 strings, "show" and "hide", I opted not for a boolean in case of future expansion of the option.

  2. I updated Locale.time to hide seconds. This also removes seconds from the session list timestamps, but I think they’re even less necessary there.

Let me know if the changes look good

@github-actions github-actions bot force-pushed the dev branch 2 times, most recently from 917250b to f4593c6 Compare November 22, 2025 05:02
@rekram1-node
Copy link
Collaborator

If u can resolve the conflict then this one is good to go, thanks!

@val-2
Copy link
Contributor Author

val-2 commented Nov 22, 2025

@rekram1-node Conflicts are resolved

@rekram1-node rekram1-node merged commit 59742fb into sst:dev Nov 22, 2025
@rekram1-node
Copy link
Collaborator

@val-2 thanks! Our designer had more iteration ideas but I am gonna merge ur pr in and we may do some tweaks to it after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Show end time after agent finishes working on a prompt

3 participants