Fix redirect URI security vulnerability and improve documentation #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaswallerstedt
force-pushed
the
fix/redirect-uri-security-and-docs
branch
2 times, most recently
from
2d664d2 to
2d77dfc
Compare
niklaswallerstedt
force-pushed
the
fix/redirect-uri-security-and-docs
branch
3 times, most recently
from
36ca824 to
ed24743
Compare
niklaswallerstedt
force-pushed
the
fix/redirect-uri-security-and-docs
branch
from
ed24743 to
a1c5cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix redirect URI security vulnerability
Resolves #299
Fixes malformed URL bypass vulnerability where
redirect_uri=https:evil.comcould redirect to external domains. The fix ensures proper validation and returns HTTP 400 forinvalid redirect URIs.
Also adds comprehensive security documentation explaining the default behavior and providing guidance for implementing stricter per-client validation in production environments.