fix(issuer): ensure implicit flow complies with RFC 6749 Section 4.2.2 #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove refresh_token from implicit flow response (MUST NOT be issued per RFC 6749 § 4.2.2) - Add required token_type parameter set to "Bearer" (REQUIRED per RFC 6749 § 4.2.2) - Add expires_in parameter to response (RECOMMENDED per RFC 6749 § 4.2.2) - Add test coverage verifying RFC 6749 compliance Per RFC 6749 Section 4.2.2 (https://tools.ietf.org/html/rfc6749#section-4.2.2): "The authorization server MUST NOT issue a refresh token" Additionally, RFC 9700 Section 2.1.2 (OAuth 2.0 Security BCP) recommends against using implicit flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 6749 Section 4.2.2 (https://tools.ietf.org/html/rfc6749#section-4.2.2):
"The authorization server MUST NOT issue a refresh token"