Add OpenAuth client in golang #251
Conversation
|
|
Hi @natac13, are you still working on this? I've forked your branch and tested it myself, and it's been working well! Though I got some comments that I'd like to add. |
@muhwyndhamhp Any feedback is welcome. I was 'done' with this to the point of waiting for a review. 🤞 |
wyndhamharyata
left a comment
wyndhamharyata
left a comment
There was a problem hiding this comment.
It's already good IMO, just had one minor implementation nitpick
| return nil, ErrInvalidAccessToken | ||
| } | ||
|
|
||
| var typ interface{} |
There was a problem hiding this comment.
I would assume that the usage of interface{} here is to avoid panic due to type mismatch.
I've checked internal implementation on Token.Get() and it should be safe to declare typ directly as string and it won't cause panic but will return error as value.
| issuerCache: map[string]WellKnown{}, | ||
| jwksCache: map[string]jwk.Set{}, | ||
| mu: sync.RWMutex{}, | ||
| subjectSchema: &input.SubjectSchema, |
There was a problem hiding this comment.
This is not a critique, but I'd say this is an uncommon but very neat way to validate Subject. Never think of it this way!
Fixes sst#250 - [x] handle form POST - [x] resolve AWS marketplace token w/ AWS `ResolveCustomer` - [x] store AWS marketplace info in tenants table - [x] notify Fabric of AWS subscription through Hasura events (cf. existing Stripe hooks); see DefangLabs/defang-mvp#2096 - [ ] handle `x-amzn-marketplace-offer-type=free-trial` form param --------- Co-authored-by: Raphael Titsworth-Morin <[email protected]> Co-authored-by: Eric Liu <[email protected]> Co-authored-by: Eric Liu <[email protected]>
3 participants
No description provided.