Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this?
This PR fixes a build issue on some platforms (in particular, one of our nodes).
What's the exact issue?
The lookup mechanism for angle-bracketed include directives (i.e.
#include <cpuid.h>
) is implementation defined. In some settings, the lookup mechanism will search the current directory before any system paths. This can cause build issues for this project that look as follows:The reason why is because the
#include<cpuid.h>
is seemingly includingcpuid.h
itself (the#pragma once
probably guards this in a way that#ifndef
wouldn't) and thus the__cpuid_count
function is never defined.It turns out that renaming
cpuid.h
tocpu_id.h
is sufficient to fix the issue.