Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:HttpLoggingInterceptor bodyIsStreaming add other stream type assert #8240

Closed
wants to merge 1 commit into from

Conversation

Felix8029
Copy link

No description provided.

@yschimke
Copy link
Collaborator

yschimke commented Feb 5, 2024

I don't think application/octet-stream indicates a streaming response.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types

Generic binary data (or binary data whose true type is unknown) is application/octet-stream.

Are you trying to just not output binary data here?

I guess you could add to bodyHasUnknownEncoding or add a bodyHasBinaryData.

Could you start with what you are trying to achieve?

@JakeWharton
Copy link
Collaborator

It also might not be binary data, just data of unknown mime type. Probably best to rely on the regular binary detection still.

@yschimke
Copy link
Collaborator

Closing, happy to discuss if I've misunderstood something.

@yschimke yschimke closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants