Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Proxy test #8235

Merged
merged 2 commits into from
Feb 3, 2024
Merged

HTTP Proxy test #8235

merged 2 commits into from
Feb 3, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Feb 3, 2024

Investigating #8233

Will check in with one test disabled until a fix is made.

}

@Test
@Disabled("https://github.com/square/okhttp/issues/8233")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing with

java.io.IOException: Required SETTINGS preface not received
	at okhttp3.internal.http2.Http2Reader.readConnectionPreface(Http2Reader.kt:76)
	at okhttp3.internal.http2.Http2Connection$ReaderRunnable.invoke(Http2Connection.kt:635)
	at okhttp3.internal.http2.Http2Connection$ReaderRunnable.invoke(Http2Connection.kt:627)
	at okhttp3.internal.concurrent.TaskQueue$execute$1.runOnce(TaskQueue.kt:119)
	at okhttp3.internal.concurrent.TaskRunner.runTask(TaskRunner.kt:124)
	at okhttp3.internal.concurrent.TaskRunner.access$runTask(TaskRunner.kt:44)
	at okhttp3.internal.concurrent.TaskRunner$runnable$1.run(TaskRunner.kt:73)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

@yschimke yschimke requested a review from swankjesse February 3, 2024 13:11
@yschimke yschimke marked this pull request as draft February 3, 2024 13:13
@yschimke yschimke added the containers Container tests (Docker) label Feb 3, 2024
@yschimke yschimke marked this pull request as ready for review February 3, 2024 14:15
@yschimke
Copy link
Collaborator Author

yschimke commented Feb 3, 2024

@swankjesse test only, requesting post review.

@yschimke yschimke merged commit f9b633e into square:master Feb 3, 2024
40 checks passed
Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with follow-up!
#8325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Container tests (Docker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants