Allow constructor injection of MockWebServer

[yschimke]

No description provided.

[yschimke]

@swankjesse interestingly, some failures on an earlier build were familiar flaky tests. maybe a clue on why it's failing.

https://github.com/square/okhttp/actions/runs/7512760479/job/20453782860

HttpOverHttp2Test > recoverFromCancelReusesConnection(Protocol, MockWebServer) > [2] h2 FAILED
    java.lang.IllegalStateException: shutdown() already called
        at mockwebserver3.MockWebServer.start(MockWebServer.kt:332)
        at mockwebserver3.MockWebServer.start(MockWebServer.kt:322)
        at mockwebserver3.MockWebServer.start(MockWebServer.kt:309)

[yschimke]

Will test on android as I think that's why we needed the extend with.

resolved: "configurationParameters" to "junit.jupiter.extensions.autodetection.enabled=true"

[swankjesse]

LGTM

[swankjesse]

Do our end-users need to do this? JUnit 5 is such a mess.

[TWiStErRob]

don't "need to", users have the option of

• using the extension directly by annotating test class.
• using the extension directly by annotating an annotation to collect extensions
• setting this property to magically apply extension to all tests

They must consume extensions somehow for sure, but this is not much different than adding a rule to a class in JUnit 4, right?

[TWiStErRob]

Oh, just realized that this is in internal package, but it's public API, as users can choose how to use the extensions (you choose to use the atuodetection in this project). Could this be made actual API? @swankjesse

[swankjesse]

I think we should change our MockWebServer JUnit 5 extension API to use an annotation on each annotated class. It’s two imports instead of JUnit 4’s single import, but it’s self-contained in the test class.