Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] default to Loom on #8168

Closed
wants to merge 3 commits into from
Closed

Conversation

yschimke
Copy link
Collaborator

For discussion of #8167

Unlikely to land

@JakeWharton
Copy link
Collaborator

Seems like a better case for MR jars than a runtime check. This is going to cause deoptimization on Android and errors in ProGuard/R8/Graal nativeimage as written.

@yschimke
Copy link
Collaborator Author

No plan to land, closing.

Failing on API checks

> Task :okhttp:animalsnifferMain FAILED

[Undefined reference | android-api-level-21-5.0.1_r2] okhttp3.(Dispatcher.kt:105)
  >> java.util.concurrent.ExecutorService java.util.concurrent.Executors.newVirtualThreadPerTaskExecutor()

[Undefined reference | java18-1.0] okhttp3.(Dispatcher.kt:105)
  >> java.util.concurrent.ExecutorService java.util.concurrent.Executors.newVirtualThreadPerTaskExecutor()

@yschimke yschimke closed this Jan 14, 2024
@yschimke yschimke deleted the loom_on branch December 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants