Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid checking file metadata in graal tests #8161

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Avoid checking file metadata in graal tests #8161

merged 2 commits into from
Dec 24, 2023

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke added the loom Relates to Loom JDK support label Dec 24, 2023
@yschimke yschimke changed the title Avoid checking file metadata in loom tests Avoid checking file metadata in graal tests Dec 24, 2023
@yschimke yschimke added graal GraalVM related and removed loom Relates to Loom JDK support labels Dec 24, 2023
@yschimke yschimke requested a review from swankjesse December 24, 2023 09:32
@yschimke
Copy link
Collaborator Author

@swankjesse requesting post review.

Likely I should dig, but we know the code is working, just not this arbitrary test that looks for a resource with Okio FileSystem.RESOURCES.

@yschimke yschimke merged commit d4ca39b into square:master Dec 24, 2023
57 checks passed
swankjesse
swankjesse reviewed Dec 24, 2023
View reviewed changes
Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@yschimke yschimke deleted the loom branch December 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse swankjesse left review comments

Assignees
No one assigned
Labels
graal GraalVM related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @swankjesse