Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to the kotlin JVM plugin #8149

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Switch back to the kotlin JVM plugin #8149

merged 3 commits into from
Dec 20, 2023

Conversation

swankjesse
Copy link
Collaborator

This does a ton of file moves from jvmMain to main, and jvmTest to test.

@swankjesse swankjesse requested review from yschimke and oldergod and removed request for yschimke December 20, 2023 14:46
@swankjesse
Copy link
Collaborator Author

⚠️

Ugh, I did a stacked PRs fail on this one. Viewing only the first 2 commits in the diff view should help.

@swankjesse swankjesse requested a review from yschimke December 20, 2023 15:30
yschimke
yschimke approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM reviewing the first two commits

@swankjesse swankjesse merged commit c056530 into master Dec 20, 2023
19 checks passed
@swankjesse swankjesse deleted the jwilson.1219.demultiplatform branch December 20, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

@oldergod oldergod Awaiting requested review from oldergod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swankjesse @yschimke @squarejesse