Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests against MockServer and a SOCKS5 proxy #8057

Merged
merged 23 commits into from
Jan 20, 2024
Merged

Add tests against MockServer and a SOCKS5 proxy #8057

merged 23 commits into from
Jan 20, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Oct 15, 2023 •
edited
Loading

Defining a test using testcontainers, docker.

In this example using MockServer, with http and https.

Next: test against a Socks Proxy.

@yschimke
Copy link
Collaborator Author

Somewhat a fork of https://github.com/square/okhttp/pull/7645/files

@yschimke yschimke changed the title [Testing] Add a simple test of a service from Docker Add a simple test of a service from Docker Jan 14, 2024
@yschimke yschimke added containers Container tests (Docker) android Relates to usage specifically on Android and removed containers Container tests (Docker) android Relates to usage specifically on Android labels Jan 14, 2024
@yschimke yschimke marked this pull request as ready for review January 14, 2024 12:29
@yschimke yschimke requested a review from swankjesse January 14, 2024 12:29
@yschimke yschimke changed the title Add a simple test of a service from Docker Add tests against Docker Jan 14, 2024
@yschimke yschimke changed the title Add tests against Docker Add tests against MockServer and a SOCKS5 proxy Jan 14, 2024
@yschimke
Copy link
Collaborator Author

@swankjesse requesting post review. CI only and would like to have to test issues on bugs like SOCKS support.

@yschimke yschimke merged commit a990f78 into square:master Jan 20, 2024
20 checks passed
swankjesse
swankjesse reviewed Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yschimke yschimke deleted the test_containers branch December 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse swankjesse left review comments

Assignees
No one assigned
Labels
containers Container tests (Docker)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @swankjesse