Skip to content

Commit

Permalink
Refine doc and comments about android test (#7694)
Browse files Browse the repository at this point in the history
  • Loading branch information
TangHuaiZhe authored Feb 14, 2023
1 parent 64a9c8e commit d7c3ced
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ org.gradle.caching=true
Running Android Tests
---------------------

$ ANDROID_SDK_ROOT=PATH_TO_ANDROID_HOME/sdk ./gradlew :android-test:connectedCheck
$ ANDROID_SDK_ROOT=PATH_TO_ANDROID_HOME/sdk ./gradlew :android-test:connectedCheck -PandroidBuild=true

Committer's Guides
------------------
Expand Down
2 changes: 1 addition & 1 deletion android-test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ $ adb logcat '*:E' OkHttp:D Http2:D TestRunner:D TaskRunner:D OkHttpTest:D GnssH
3. Run tests using gradle

```
$ ANDROID_SDK_ROOT=/Users/myusername/Library/Android/sdk ./gradlew :android-test:connectedCheck
$ ANDROID_SDK_ROOT=/Users/myusername/Library/Android/sdk ./gradlew :android-test:connectedCheck -PandroidBuild=true
...
> Task :android-test:connectedDebugAndroidTest
...
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ import okhttp3.Headers
import org.junit.jupiter.api.BeforeEach

/**
* Run with "./gradlew :android-test:connectedCheck" and make sure ANDROID_SDK_ROOT is set.
* Run with "./gradlew :android-test:connectedCheck -PandroidBuild=true" and make sure ANDROID_SDK_ROOT is set.
*/
@ExtendWith(MockWebServerExtension::class)
@Tag("Slow")
Expand Down
2 changes: 1 addition & 1 deletion docs/contribute/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ org.gradle.caching=true
Running Android Tests
---------------------

$ ANDROID_SDK_ROOT=PATH_TO_ANDROID_HOME/sdk ./gradlew :android-test:connectedCheck

This comment has been minimized.

Copy link
@Sniffentrevon1

Sniffentrevon1 Jul 30, 2023

PandroidBuild=true

$ ANDROID_SDK_ROOT=PATH_TO_ANDROID_HOME/sdk ./gradlew :android-test:connectedCheck -PandroidBuild=true

Committer's Guides
------------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import org.junit.jupiter.api.extension.ExtendWith
import org.opentest4j.TestAbortedException

/**
* Run with "./gradlew :android-test:connectedCheck" and make sure ANDROID_SDK_ROOT is set.
* Run with "./gradlew :android-test:connectedCheck -PandroidBuild=true" and make sure ANDROID_SDK_ROOT is set.
*/
@ExtendWith(MockWebServerExtension::class)
class AndroidAsyncDnsTest {
Expand Down

0 comments on commit d7c3ced

Please sign in to comment.