Skip to content

Commit

Permalink
Simplify gradle kts (#6931)
Browse files Browse the repository at this point in the history
  • Loading branch information
Goooler authored Nov 27, 2021
1 parent d9a65a8 commit 8debc78
Show file tree
Hide file tree
Showing 14 changed files with 23 additions and 37 deletions.
8 changes: 4 additions & 4 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ subprojects {
exclude("**/CipherSuite.java")
}

val checkstyleConfig by configurations.creating
val checkstyleConfig: Configuration by configurations.creating
dependencies {
checkstyleConfig(Dependencies.checkStyle) {
isTransitive = false
Expand All @@ -110,7 +110,7 @@ subprojects {
annotation = "okhttp3.internal.SuppressSignatureCheck"
sourceSets = listOf(project.sourceSets["main"])
}
val signature by configurations.getting
val signature: Configuration by configurations.getting
dependencies {
signature(Dependencies.signatureAndroid21)
signature(Dependencies.signatureJava18)
Expand All @@ -129,7 +129,7 @@ subprojects {
val platform = System.getProperty("okhttp.platform", "jdk9")
val testJavaVersion = System.getProperty("test.java.version", "11").toInt()

val testRuntimeOnly by configurations.getting
val testRuntimeOnly: Configuration by configurations.getting
dependencies {
testRuntimeOnly(Dependencies.junit5JupiterEngine)
testRuntimeOnly(Dependencies.junit5VintageEngine)
Expand Down Expand Up @@ -236,6 +236,6 @@ subprojects {
}
}

tasks.withType<Wrapper> {
tasks.wrapper {
distributionType = Wrapper.DistributionType.ALL
}
3 changes: 1 addition & 2 deletions mockwebserver-deprecated/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import com.android.build.gradle.internal.tasks.factory.dependsOn
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension
import me.champeau.gradle.japicmp.JapicmpTask

plugins {
Expand Down Expand Up @@ -48,6 +47,6 @@ tasks.register<JapicmpTask>("japicmp") {
}.let(tasks.check::dependsOn)


configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
3 changes: 1 addition & 2 deletions mockwebserver-junit4/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension

plugins {
kotlin("jvm")
Expand All @@ -21,6 +20,6 @@ dependencies {
testImplementation(Dependencies.assertj)
}

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
3 changes: 1 addition & 2 deletions mockwebserver-junit5/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension

plugins {
kotlin("jvm")
Expand Down Expand Up @@ -30,6 +29,6 @@ dependencies {
testImplementation(Dependencies.kotlinJunit5)
}

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
3 changes: 1 addition & 2 deletions mockwebserver/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension

plugins {
kotlin("jvm")
Expand All @@ -24,6 +23,6 @@ dependencies {
testImplementation(Dependencies.assertj)
}

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
5 changes: 2 additions & 3 deletions okcurl/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import com.android.build.gradle.internal.tasks.factory.dependsOn
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension
import java.nio.charset.StandardCharsets
import org.apache.tools.ant.taskdefs.condition.Os

Expand Down Expand Up @@ -62,7 +61,7 @@ graal {
}
}

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}

Expand All @@ -73,5 +72,5 @@ tasks.register<Copy>("copyResourcesTemplates") {
filteringCharset = StandardCharsets.UTF_8.toString()
}.let {
tasks.processResources.dependsOn(it)
tasks.named("javaSourcesJar").dependsOn(it)
tasks["javaSourcesJar"].dependsOn(it)
}
6 changes: 3 additions & 3 deletions okhttp-bom/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ dependencies {
}
}

extensions.configure<PublishingExtension> {
publications.create("maven", MavenPublication::class) {
from(project.components.getByName("javaPlatform"))
publishing {
publications.create<MavenPublication>("maven") {
from(project.components["javaPlatform"])
}
}
3 changes: 1 addition & 2 deletions okhttp-brotli/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension

plugins {
kotlin("jvm")
Expand All @@ -25,6 +24,6 @@ dependencies {
testImplementation(Dependencies.assertj)
}

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
3 changes: 1 addition & 2 deletions okhttp-dnsoverhttps/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension

plugins {
kotlin("jvm")
Expand All @@ -27,6 +26,6 @@ dependencies {
testImplementation(Dependencies.assertj)
}

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
3 changes: 1 addition & 2 deletions okhttp-logging-interceptor/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import com.android.build.gradle.internal.tasks.factory.dependsOn
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension
import me.champeau.gradle.japicmp.JapicmpTask

plugins {
Expand Down Expand Up @@ -41,6 +40,6 @@ tasks.register<JapicmpTask>("japicmp") {
isIncludeSynthetic = true
}.let(tasks.check::dependsOn)

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
3 changes: 1 addition & 2 deletions okhttp-sse/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import com.android.build.gradle.internal.tasks.factory.dependsOn
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension
import me.champeau.gradle.japicmp.JapicmpTask

plugins {
Expand Down Expand Up @@ -43,6 +42,6 @@ tasks.register<JapicmpTask>("japicmp") {
)
}.let(tasks.check::dependsOn)

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
3 changes: 1 addition & 2 deletions okhttp-tls/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import com.android.build.gradle.internal.tasks.factory.dependsOn
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension
import me.champeau.gradle.japicmp.JapicmpTask

plugins {
Expand Down Expand Up @@ -49,6 +48,6 @@ tasks.register<JapicmpTask>("japicmp") {
)
}.let(tasks.check::dependsOn)

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
3 changes: 1 addition & 2 deletions okhttp-urlconnection/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import com.android.build.gradle.internal.tasks.factory.dependsOn
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension
import me.champeau.gradle.japicmp.JapicmpTask

plugins {
Expand Down Expand Up @@ -44,6 +43,6 @@ tasks.register<JapicmpTask>("japicmp") {
}.let(tasks.check::dependsOn)


configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}
11 changes: 4 additions & 7 deletions okhttp/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import com.android.build.gradle.internal.tasks.factory.dependsOn
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.KotlinJvm
import com.vanniktech.maven.publish.MavenPublishBaseExtension
import java.nio.charset.StandardCharsets
import me.champeau.gradle.japicmp.JapicmpTask

Expand Down Expand Up @@ -61,12 +60,10 @@ normalization {
}

// Expose OSGi jars to the test environment.
configurations {
create("osgiTestDeploy")
}
val osgiTestDeploy: Configuration by configurations.creating

tasks.register<Copy>("copyOsgiTestDeployment") {
from(configurations["osgiTestDeploy"])
from(osgiTestDeploy)
into("$buildDir/resources/test/okhttp3/osgi/deployments")
}.let(tasks.test::dependsOn)

Expand Down Expand Up @@ -173,7 +170,7 @@ tasks.register<JapicmpTask>("japicmp") {
)
}.let(tasks.check::dependsOn)

configure<MavenPublishBaseExtension> {
mavenPublishing {
configure(KotlinJvm(javadocJar = JavadocJar.Dokka("dokkaGfm")))
}

Expand All @@ -184,6 +181,6 @@ tasks.register<Copy>("copyJavaTemplates") {
filteringCharset = StandardCharsets.UTF_8.toString()
}.let {
tasks.compileKotlin.dependsOn(it)
tasks.named("javaSourcesJar").dependsOn(it)
tasks["javaSourcesJar"].dependsOn(it)
}

0 comments on commit 8debc78

Please sign in to comment.