Skip to content

Bottom gravity and autoscroll improvements#576

Merged
johnnewman-square merged 2 commits intomainfrom
johnnewman/bug/gravity-offset-override
May 20, 2025
Merged

Bottom gravity and autoscroll improvements#576
johnnewman-square merged 2 commits intomainfrom
johnnewman/bug/gravity-offset-override

Conversation

@johnnewman-square
Copy link
Copy Markdown
Contributor

@johnnewman-square johnnewman-square commented May 16, 2025

When AutoScrollAction is engaged, these changes will temporarily ignore the bottom gravity overrides while scrolling to the desired item. This is a lighter alternative to the previous implementation, which asked the collection view to lay out its items before scrolling.

Checklist

Please do the following before merging:

  • Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.

@johnnewman-square johnnewman-square marked this pull request as ready for review May 16, 2025 17:42
Comment thread ListableUI/Sources/ListView/ListView.swift
Comment thread ListableUI/Sources/ListView/ListView.swift
Copy link
Copy Markdown
Contributor

@g-mark g-mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@johnnewman-square johnnewman-square merged commit 88e4b81 into main May 20, 2025
4 checks passed
@johnnewman-square johnnewman-square deleted the johnnewman/bug/gravity-offset-override branch May 20, 2025 17:38
johnnewman-square added a commit that referenced this pull request May 20, 2025
This release includes the bottom gravity and autoscroll improvements
from #576.
kyleve pushed a commit that referenced this pull request Jul 24, 2025
…-headerfooters

* origin/main:
  build: set up tuist (#584)
  Bumping versions to 16.3.0 (#589)
  Reset scroll position if list identifier changes (#588)
  Bumping versions to 16.2.0 (#587)
  Adding a completion handler to the `scrollToSection` API. (#585)
  Adding a programmatic scroll completion handler (#582)
  Remove iOS 19 (26) cap of the collection view first responder workaround (#581)
  Bumping versions to 16.1.0 (#583)
  Update for Blueprint 6.0.0 (#580)
  Bumping versions to 16.0.4. (#579)
  Update the first responder resignation workaround to be enabled by default and cap at < iOS 19 [UI-8849] (#578)
  Bumping versions to 16.0.3 (#577)
  Bottom gravity and autoscroll improvements (#576)
  Bumping versions to 16.0.2 (#574)
  Addressing an AutoScrollAction issue when using VerticalLayoutGravity.bottom (#572)
  release: Prepare 16.0.1 release (#569)
  Fix reordering crash introduced in 16.0 (#568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants