Skip to content

minor build updates 2023-01 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

brody4hire
Copy link

@brody4hire brody4hire commented Jan 9, 2023

includes android-database-sqlcipher 4.5.3 update from PR #42


UPDATED STATUS:

I would now favor this over the major updates proposed in PR #44

I would now favor the major updates proposed in PR #44.

@brody4hire brody4hire marked this pull request as ready for review January 9, 2023 01:44
@brody4hire
Copy link
Author

brody4hire commented Jan 9, 2023

I am thinking again it would be ideal to close this in favor of the major updates proposed in PR #44, hope one of these proposals will be considered to keep this test suite updated.

@brody4hire brody4hire marked this pull request as draft January 9, 2023 21:38
@brody4hire
Copy link
Author

Looks like e113fa2 would be overridden by 2cf379d on master ... I would like to rebase the other changes

@brody4hire brody4hire force-pushed the minor-build-updates-2023-01 branch from 5e99082 to aac516e Compare January 10, 2023 20:04
@brody4hire brody4hire marked this pull request as ready for review January 10, 2023 20:37
@brody4hire
Copy link
Author

I am now closing this in favor of the major build updates I proposed in PR #44, don't think #44 will break anything now that we are using SDK 33.

@brody4hire brody4hire closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant