ci: integrate Pages deployment into CI workflow#40
Merged
Conversation
… on tag events)\n\nTag push events trigger GITHUB_TOKEN restrictions that prevent deploy_pages from assigning a runner. Switch to workflow_dispatch only.
…Z file WASM test - License: change all @license MIT to @license MulanPSL-2.0 - License: remove full MIT license text from report.h - Naming: rename all TLV references to ILV (Indexed-Length-Value) in comments - Naming: update error messages and help text from TLV to ILV - CI/WASM: add real SPZ file testing using spz-anime-text2scene-bench dataset - CI/WASM: test inspectSpz, dumpTrailer, listRegisteredExtensions, getCompatibilityBoard APIs - CI/WASM: test UI rendering (no n/a in panels) for v3 and v4 SPZ files - Fix: createUnavailableMethod returns Promise.reject instead of sync throw - Fix: listRegisteredExtensions/getCompatibilityBoard fallbacks return Promise.resolve
…ynthetic test coverage - Add tests/fixtures/ with classroom_anime v3+v4 real SPZ files (smallest dataset: 8.47/8.66 MB) - Remove remote git clone of spz-anime-text2scene-bench (unreliable + path typos) - Copy real fixtures from tests/fixtures/ to build-wasm/site/ in CI - Test all 4 files: synthetic_v3, synthetic_v4, real_v3, real_v4 - Each file tests: inspectSpz, dumpTrailer, listRegisteredExtensions, getCompatibilityBoard - UI upload test uses real_v4.spz (classroom_anime v4)
- Add deploy_pages job to ci.yml that runs after wasm + build succeed - Only deploys on main branch push events - Reuses wasm-build artifact from wasm job - Keeps pages.yml with workflow_dispatch as fallback manual trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrate GitHub Pages deployment directly into the CI workflow.
Changes
deploy_pagesjob to ci.yml that runs afterwasm+buildsucceedwasm-buildartifact from thewasmjob (no redundant rebuild)pages.ymlwithworkflow_dispatchas a fallback manual triggerWhy
Previously Pages deployment was decoupled from CI:
pages.ymlvia workflow_dispatchNow CI passes → Pages deploys automatically.
Test Plan