PR: Add FreeBSD to test_user_sitepackages_in_pathlist
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'user site-packages in pathlist' test is the only one that fails on FreeBSD because the OS is not recognized. FreeBSD uses the same .local path as Darwin, so you can simply extend the if statement.
ccordoba12
reviewed
Jan 26, 2023
There was a problem hiding this comment.
Thanks for your contribution @rhurlin! I left a small suggestion for you below, otherwise looks good to me.
In case you don't know how to work with suggestions on Github, please read these docs.
ccordoba12
changed the title
test_user_sitepackages_in_pathlist
Co-authored-by: Carlos Cordoba <[email protected]>
|
Sorry, this should not have happened. |
ccordoba12
added a commit
that referenced
this pull request
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'user site-packages in pathlist' test is the only one that fails on FreeBSD because the OS is not recognized. FreeBSD uses the same .local path as Darwin, so you can simply extend the if statement.