Open
Conversation
added 2 commits
December 8, 2020 08:33
springwq
reviewed
Dec 10, 2020
| end | ||
| end | ||
|
|
||
| describe '#feed' do |
Owner
There was a problem hiding this comment.
feed 方法测试需要加强，需要考虑 no feeds, 1 feed 和 many feeds 的情况
springwq
reviewed
Dec 10, 2020
spec/requests/users_spec.rb
Outdated
|
|
||
| describe '#create' do | ||
| # TODO | ||
| context "success" do |
Owner
There was a problem hiding this comment.
context 一般这样写 context 'where create successfully'
springwq
reviewed
Dec 10, 2020
spec/requests/users_spec.rb
Outdated
|
|
||
|
|
||
| describe '#destroy' do | ||
| # TODO |
Owner
|
added 3 commits
December 10, 2020 08:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add rspec