Support for AMD and corrected browser #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @harryxue1999! thank you for taking the time to propose this change and sorry for the belated response! turning arc.js into a UMD is still definitely an option but at this point it has also become pretty common for library authors to publish a bare ES module and let the consumer handle transpilation. i'll need to chew on this a bit but i'm interested in more feedback if you (or anyone else) has opinions on the topic. (maybe something like this? felixge/node-dateformat#183) |
|
a few more years have passed and i'm more convinced than ever that a native ESM rewrite would be the way to go. i don't have any plans to tackle anything like that myself, but a PR would definitely be welcome. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window)