Generics improvement. #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi John,
I'm following your Spring 6 course on Udemy, and I really like it.
Great job. I was following lesson 196 from section 19, and I think I saw an improvement regarding the BeerDTOPageImpl.
In the lesson you used the fully qualified name of the BeerDTO class to make it work.
But I believe that isn't necessary, but because of the Generic right after "public class BeerDTOPageImpl<BeerDTO", BeerDTO was seen as a Generic type identifier (or what you may call it). If you remove that one, then you can use PageImpl instead of the fully qualified name.
Kind regards,
Alexander van Vark