Remove dependency on oauth2-oidc-sdk inside NimbusOpaqueTokenIntrospector #16634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Svanberg <[email protected]>
The tests that went through opaque token introspection rely on mocking a specific method in the RestOperations interface which is very brittle and hampers the ability to refactor internals. They are changed to instead make actual HTTP requests to a MockWebServer instead allowing refactoring changes. This is necessary to allow the implementation to be swapped from NimbusOpaqueTokenIntrospector to SpringOpaqueTokenIntrospector because the latter uses RestOperations#exchange(String, ParameterizedType) instead of RestOperations#exchange(String, String) of the former. Signed-off-by: Andreas Svanberg <[email protected]>
Signed-off-by: Andreas Svanberg <[email protected]>
The tests that went through opaque token introspection rely on mocking a specific method in the RestOperations interface which is very brittle and hampers the ability to refactor internals. They are changed to instead make actual HTTP requests to a MockWebServer instead allowing refactoring changes. This is necessary to allow the implementation to be swapped from NimbusOpaqueTokenIntrospector to SpringOpaqueTokenIntrospector because the latter uses RestOperations#exchange(String, ParameterizedType) instead of RestOperations#exchange(String, String) of the former. Signed-off-by: Andreas Svanberg <[email protected]>
Signed-off-by: Andreas Svanberg <[email protected]>
Signed-off-by: Andreas Svanberg <[email protected]>
They require the implementation to call a specific method on the RestOperations interface. Change to use a MockWebServer to allow refactoring without the tests breaking. Signed-off-by: Andreas Svanberg <[email protected]>
There is no verification of issuer at all. The only reason the test still "passes" is because the JSON response has the active attribute as the JSON string "true" rather than the boolean true which is not accepted. Choose to remove the test rather than adding issuer verification since the class is deprecated and will most likely be removed in a future release. Signed-off-by: Andreas Svanberg <[email protected]>
Signed-off-by: Andreas Svanberg <[email protected]>
Signed-off-by: Andreas Svanberg <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR, @asvanberg, however |
jzheaux
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NimbusOpaqueTokenIntrospectornow delegates toSpringOpaqueTokenIntrospector.Required a lot of test changes since they are all mock-based relying on the implementation calling a specific method in the
RestOperationsinterface and the two implementations differ in which method they call even though they are functionally the same. Tests were changed to use aMockWebServerand make real HTTP requests to enable the internals to be freely refactored.One step of gh-14245