Fix JdbcUserCredentialRepository Save #16621
Open
+66
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Feb 24, 2025
| @@ -133,6 +152,21 @@ public void delete(Bytes credentialId) { | |||
| @Override | |||
| public void save(CredentialRecord record) { | |||
| Assert.notNull(record, "record cannot be null"); | |||
| boolean existsRecord = null != this.findByCredentialId(record.getCredentialId()); | |||
There was a problem hiding this comment.
I think the following logic achieves the same outcome:
int rows = updateCredentialRecord(record); // change to return the number of rows affected
if (rows == 0) {
insertCredentialRecord(record);
}This would complete more quickly and also be less load on the database.
There was a problem hiding this comment.
Good solution. I think we can do this polish in other places with similar logic.
jzheaux
added
in: web
|
Also, will you please rebase to |
Closes spring-projectsgh-16620 Signed-off-by: Max Batischev <[email protected]>
|
Hi @jzheaux . Thanks for your feedback. This component was introduced in current version, so it is not in |
franticticktick
force-pushed
the
gh-16620
branch
from
2f41603 to
af56c22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16620