Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Http403ForbiddenEntryPoint to use HttpStatus.FORBIDDEN.value #16616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactored Http403ForbiddenEntryPoint to use HttpStatus.FORBIDDEN.value #16616

wants to merge 1 commit into from

Conversation

yelm-212
Copy link

Fixes #16615

  • Replaced hardcoded 403 in Http403ForbiddenEntryPoint with HttpStatus.FORBIDDEN.value()
  • Ensures consistency with BasicAuthenticationEntryPoint and DelegatingAuthenticationEntryPoint
  • No breaking changes, maintains existing behavior

@yelm-212 yelm-212 marked this pull request as ready for review February 18, 2025 04:32
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 18, 2025
@jzheaux jzheaux mentioned this pull request Feb 24, 2025
Closed
@jzheaux jzheaux self-assigned this Feb 24, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 24, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Feb 24, 2025

Hi, @yelm-212, thanks for your contribution!

Will you please sign your commit?

Also, will you edit your commit message to include the issue number on its own line like this:

Closes gh-16615

Lastly, would you please update the copyright year in Http403ForbiddenEntryPoint?

@jzheaux jzheaux added the status: waiting-for-feedback We need additional information before we can continue label Feb 24, 2025
@yelm-212 yelm-212 force-pushed the fix-http-status-consistency branch from bb1bd8c to 51d4eac Compare February 25, 2025 06:08
@yelm-212 yelm-212 force-pushed the fix-http-status-consistency branch from 51d4eac to 5a5ad51 Compare February 25, 2025 06:16
@yelm-212
Copy link
Author

I've made the requested updates. Let me know if there's anything else I should adjust. Thanks!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) status: feedback-provided Feedback has been provided type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Hardcoded 403 in Http403ForbiddenEntryPoint with HttpStatus.FORBIDDEN.value()
3 participants
@yelm-212 @jzheaux @spring-projects-issues