Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WebAuthnAuthenticationRequestToken Serializable #16602

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Make WebAuthnAuthenticationRequestToken Serializable #16602

merged 1 commit into from
Feb 14, 2025

Conversation

franticticktick
Copy link
Contributor

Closes gh-16481

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 14, 2025
jzheaux
jzheaux requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @franticticktick! I've left my feedback inline.

@franticticktick franticticktick changed the base branch from main to 6.4.x February 14, 2025 16:33
@jzheaux
Copy link
Contributor

jzheaux commented Feb 14, 2025

Thanks for the quick turnaround, @franticticktick. I notice that one of the tests is failing: https://github.com/spring-projects/spring-security/actions/runs/13333391842/job/37242815176?pr=16602#step:4:2380

Are you able to get that working?

@franticticktick
Copy link
Contributor Author

Hey @jzheaux , thanks for feedbak, I think I know why the test fails, I need to make this modification a841737

@franticticktick
Copy link
Contributor Author

@jzheaux everything is ok, the build passed :)

@jzheaux jzheaux self-assigned this Feb 14, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 14, 2025
@jzheaux jzheaux added this to the 6.4.3 milestone Feb 14, 2025
@jzheaux jzheaux merged commit b5a4218 into spring-projects:6.4.x Feb 14, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Feb 14, 2025

Thanks, @franticticktick, this is now merged into 6.4.x and main.

I also added a polish of 9468126 to ensure that AuthenticatorAttestation was deserializable so we could remove the transient in PublicKeyCredential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Milestone
6.4.3
Development

Successfully merging this pull request may close these issues.

Make WebAuthnAuthenticationTokenRequest Serializable
3 participants
@franticticktick @jzheaux @spring-projects-issues