Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customizable RowMappers for user details and authorities in JdbcUserDetailsManager #16561

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Add customizable RowMappers for user details and authorities in JdbcUserDetailsManager #16561

merged 5 commits into from
Feb 24, 2025

Conversation

big-cir
Copy link
Contributor

@big-cir big-cir commented Feb 10, 2025 •
edited
Loading

Overview

  • added setUserDetailsMapper method to allow customization of UserDetails mapping using RowMapper
  • added setGrantedAuthorityMapper method to allow customization of GrantedAuthority mapping using RowMapper
  • unit tests for updated methods

Related

@big-cir big-cir force-pushed the refactor/jdbc-user-details-manager-private-to-protected-methods branch from 6b6a462 to 548be22 Compare February 10, 2025 06:43
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 10, 2025
jzheaux
jzheaux requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @big-cir! Can we try composition first? I've left some feedback inline for details on how that could be done.

@big-cir big-cir force-pushed the refactor/jdbc-user-details-manager-private-to-protected-methods branch 2 times, most recently from 78af6dc to 52faf76 Compare February 14, 2025 01:00
jzheaux
jzheaux requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @big-cir, yes, that's what I'm thinking. Please see some additional feedback about the method and then let's also proceed with doing the same for mapToGrantedAuthority.

@big-cir big-cir force-pushed the refactor/jdbc-user-details-manager-private-to-protected-methods branch from 52faf76 to d506c1a Compare February 15, 2025 13:26
@big-cir
Copy link
Contributor Author

big-cir commented Feb 15, 2025 •
edited
Loading

@jzheaux,
Thank you very much for your detailed feedback on the setUserDetailsMapper method in JdbcUserDetailsManager.
I've implemented all the changes you suggested. Would you kindly review the updates when you have a moment? I'm eager to ensure the modifications meet the project's standards and your expectations.

Thank you again for your time and expertise.

@big-cir big-cir force-pushed the refactor/jdbc-user-details-manager-private-to-protected-methods branch 4 times, most recently from 7ee7de6 to 50fd7c0 Compare February 15, 2025 14:55
@big-cir
Add grantedAuthorityMapper as a class member
f06c979 
- Add unit tests for setGrantedAuthorityMapper method

Signed-off-by: dae won <[email protected]>
@big-cir big-cir force-pushed the refactor/jdbc-user-details-manager-private-to-protected-methods branch from 50fd7c0 to f06c979 Compare February 15, 2025 14:59
@big-cir big-cir changed the title Make mapToUser and mapToGrantedAuthority protected in JdbcUserDetails… Add customizable RowMappers for user details and authorities in JdbcUserDetailsManager Feb 18, 2025
@big-cir big-cir requested a review from jzheaux February 18, 2025 06:49
@jzheaux jzheaux self-assigned this Feb 24, 2025
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 24, 2025
@jzheaux jzheaux mentioned this pull request Feb 24, 2025
Closed
@jzheaux jzheaux merged commit 45b51fe into spring-projects:main Feb 24, 2025
6 checks passed
@jzheaux jzheaux added this to the 6.5.0-M3 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.0-M3
Development

Successfully merging this pull request may close these issues.

mapToUser/mapToGrantedAuthority in JdbcUserDetailsManager to become protected
3 participants
@big-cir @jzheaux @spring-projects-issues