Support custom RequestMatcher in WebAuthn filters #16517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Hi, @leshalv, and thanks for this PR. I've left a inline checklist of JavaDoc polishes. Also, will you please add tests for each of these setter methods that confirm:
- They error appropriately when
nullis given - The filter appropriately uses the provided request matcher.
Note that for the second test, the filter doesn't necessarily need to get triggered; it simply needs to be clear that the given requestMatcher was used to match the request.
...gframework/security/web/webauthn/authentication/PublicKeyCredentialRequestOptionsFilter.java
Show resolved
Hide resolved
...ngframework/security/web/webauthn/registration/PublicKeyCredentialCreationOptionsFilter.java
Show resolved
Hide resolved
.../java/org/springframework/security/web/webauthn/registration/WebAuthnRegistrationFilter.java
Show resolved
Hide resolved
.../java/org/springframework/security/web/webauthn/registration/WebAuthnRegistrationFilter.java
Show resolved
Hide resolved
...gframework/security/web/webauthn/authentication/PublicKeyCredentialRequestOptionsFilter.java
Outdated
Show resolved
Hide resolved
...ngframework/security/web/webauthn/registration/PublicKeyCredentialCreationOptionsFilter.java
Show resolved
Hide resolved
.../java/org/springframework/security/web/webauthn/registration/WebAuthnRegistrationFilter.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/security/web/webauthn/registration/WebAuthnRegistrationFilter.java
Outdated
Show resolved
Hide resolved
leshalv
changed the title
jzheaux
changed the title
jzheaux
changed the title
jzheaux
added
in: web
|
Is there anything else that needs to be changed now? @jzheaux |
|
Thanks for the updates, @leshalv! Yes, please add the tests I described here: #16517 (review) |
|
@jzheaux Take a look |
jzheaux
requested changes
Feb 20, 2025
...mework/security/web/webauthn/registration/PublicKeyCredentialCreationOptionsFilterTests.java
Outdated
Show resolved
Hide resolved
...gframework/security/web/webauthn/authentication/PublicKeyCredentialRequestOptionsFilter.java
Show resolved
Hide resolved
.../org/springframework/security/web/webauthn/registration/WebAuthnRegistrationFilterTests.java
Outdated
Show resolved
Hide resolved
jzheaux
approved these changes
Feb 25, 2025
jzheaux
pushed a commit
to leshalv/spring-security
that referenced
this pull request
Feb 25, 2025
Closes spring-projectsgh-16517 Signed-off-by: smallbun <[email protected]>
jzheaux
pushed a commit
to leshalv/spring-security
that referenced
this pull request
Feb 25, 2025
Closes spring-projectsgh-16517 Signed-off-by: smallbun <[email protected]>
|
Nice work, @leshalv! Note that I've rebased your branch and squashed the commits down to one. The last thing that is needed is for you to do is correct the commit signature. It appears your git username and email don't match the signature: The author and the signature need to be the same. Because you are working on |
Closes spring-projectsgh-16517 Signed-off-by: topiam <[email protected]>
leshalv
force-pushed
the
main
branch
3 times, most recently
from
f4fa2ff to
929b4a8
Compare
Author: topiam <[email protected]> Signed-off-by: topiam <[email protected]>
Signed-off-by: topiam <[email protected]>
Signed-off-by: topiam <[email protected]>
Signed-off-by: topiam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.