Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed exclusions from pulsar-client-all #1064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

panic08
Copy link
Contributor

@panic08 panic08 commented Mar 17, 2025

The improvements introduced in this PR include handling javax.activation via shading and migrating from javax to jakarta. Given these changes, we should remove some of the now unnecessary exclusions.

Fix #963

@panic08 panic08 force-pushed the remove-no-longer-needed-exclusions-from-pulsar-client-all branch from 083bda2 to 2fcf1a3 Compare March 17, 2025 18:40
@onobc
Copy link
Collaborator

onobc commented Mar 17, 2025

Hi @panic08 - great to see you over here in this project 👋🏻

We just released 1.1.10 and 1.2.4 but will get this merged in soon. We intentionally did not add this change in yet as shadowing, transitive deps, and dependencies in general can be risky beyond the surface, especially when we have something like:

  • spring-boot (uses)
    • pulsar-client-all
    • spring-pulsar
    • pulsar-client-reactive
      and
  • spring-pulsar (uses)
    • pulsar-client-all
    • pulsar-client-reactive
      and
  • pulsar-client-reactive (uses)
    • pulsar-client-all

Thank you very much for the contribution. Once we branch main into 1.2.x and main is then our target for 2.0.0 we will merge this.

@onobc onobc modified the milestones: 2.0.0, 2.0.0-M1 Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove no longer needed exclusions from pulsar-client-all
2 participants