Prevent reflective invocation of private methods in web dispatcher #35352
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yongjunhong <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
requested changes
Oct 1, 2025
rstoyanchev
added
the
in: web
sbrannen
requested changes
Oct 3, 2025
There was a problem hiding this comment.
I requested a few changes.
Please also take Rossen's comment into account.
|
|
||
| if (AopUtils.isCglibProxy(bean) && Modifier.isPrivate(method.getModifiers())) { | ||
| throw new IllegalStateException( | ||
| "Cannot invoke private method [" + method.getName() + "] on a CGLIB proxy. " + |
There was a problem hiding this comment.
It would probably be good to include context about the bean in the exception message as well.
| if (AopUtils.isCglibProxy(bean) && Modifier.isPrivate(method.getModifiers())) { | ||
| throw new IllegalStateException( | ||
| "Cannot invoke private method [" + method.getName() + "] on a CGLIB proxy. " + | ||
| "Handler methods on proxied components must be public or protected. " + |
There was a problem hiding this comment.
That's not completely true. It's possible for a package-private method to be proxied.
As stated in the reference documentation:
privatemethods cannot be advised, because they cannot be overridden.- Methods that are not visible – for example, package-private methods in a parent class from a different package – cannot be advised because they are effectively private.
| } | ||
|
|
||
| @Test | ||
| void testPrivateMethodOnCglibProxyThrowsException() throws Exception { |
There was a problem hiding this comment.
Suggested change
| void testPrivateMethodOnCglibProxyThrowsException() throws Exception { | |
| void privateMethodOnCglibProxyThrowsException() throws Exception { |
We generally do not use a test prefix for test method names anymore.
That was only a requirement for JUnit 3.
Comment on lines
+236
to
+239
| private static class TestController { | ||
| public TestController() { | ||
| // Default constructor for proxy creation | ||
| } |
There was a problem hiding this comment.
Suggested change
| private static class TestController { | |
| public TestController() { | |
| // Default constructor for proxy creation | |
| } | |
| static class TestController { |
I don't think you need the explicit constructor.
sbrannen
added
the
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30938