Update Neo4j support to require Neo4j Java Driver 6.0.0 #47381

meistermeier · 2025-10-02T11:51:54Z

Upgrading the Neo4j Java driver to the next major version requires some changes:

Remove JCL helper (not needed anymore)
Adding dependency on the Neo4j Java driver's observation module for micrometer to support the new metric reporting system
minor changes regarding scheme API checks

My build setup (and general Gradle) knowledge is pretty limited and I am not sure how to make use of the Java driver BOM (https://central.sonatype.com/artifact/org.neo4j.driver/neo4j-java-driver-bom) here. Given the fact that there is already the alignment definition for Spring Data Neo4j in the dependency definition.

I couldn't find any micrometer tests with Neo4j and was not sure if this is needed and/or where to place them correctly.

Signed-off-by: Gerrit Meier <[email protected]>

snicoll · 2025-10-02T12:31:36Z

Thanks for the PR. Is that a mandatory requirement for the next RC of Spring Data?

My build setup (and general Gradle) knowledge is pretty limited and I am not sure how to make use of the Java driver BOM

FTR we can't use the BOM as it isn't one. It provides dependency management for Netty and it should not as a BOM should only provide dependency management for the dependencies of the project itself.

Signed-off-by: Gerrit Meier <[email protected]>

meistermeier · 2025-10-02T12:43:27Z

Is that a mandatory requirement for the next RC of Spring Data?

We merged the 6.0 driver upgrade in SDN to the main branch (next RC) this morning and as a supportive downstream developer, I raised this timely ;)

It provides dependency management for Netty and it should not as a BOM should only provide dependency management for the dependencies of the project itself

Thanks for looking into this, missed the definition there.

michael-simons · 2025-10-02T13:15:53Z

Hey @snicoll see neo4j/neo4j-java-driver#1707 from our colleague.

We had been unsure while adding it, the Maven manually is not 100% clear on this, at least there's nothing saying "you must not include dependencies"

We would love to hear your experience on that topic, though.

Please let us know if the declaration @meistermeier created in the Gradle file is enough or if we must change this before the PR can go in. Thank you.

Signed-off-by: Gerrit Meier <[email protected]>

meistermeier · 2025-10-02T14:18:23Z

For sure I ran the wrong build locally, should be better now.

> Task :platform:spring-boot-dependencies:bomrCheck FAILED

Neo4j Java Driver
    - Version 6.0.0 is misaligned. It should be 5.28.9.

fails now but I assume that is due to Spring Boot checking Spring Data Neo4j's version definition from a milestone branch instead of latest main.

snicoll · 2025-10-02T14:21:14Z

see neo4j/neo4j-java-driver#1707 from our colleague.

Very cool, thank you!

the Maven manually is not 100% clear on this,

I bet it isn't. They can't make such a strong stance but we can. Or rather, we can decide not to include a BOM that does not match that expectation.

The main idea is that if you have two sources of dependency management for the same artifact, it can lead to various issues (inconsistencies, warning in Maven itself, etc). Neo4J isn't at the application layer, it is a driver/library. As such, it should not have an opinion on the exact version of Netty that users should consume. If that is necessary, then shading is the right option.

snicoll · 2025-10-02T14:22:34Z

fails now but I assume that is due to Spring Boot checking Spring Data Neo4j's version definition from a milestone branch instead of latest main.

Yes. I think you should migrate to Spring Data snapshot in your PR. It's a bit odd that you migrate to the new driver whilst Spring Data Neo4J isn't upgraded. Actually, I am surprised that it even works...

michael-simons · 2025-10-02T14:31:15Z

I bet it isn't. They can't make such a strong stance but we can. Or rather, we can decide not to include a BOM that does not match that expectation.

Thanks @snicoll This makes sense and we will fix that in the next release. The intention behind was this: The latest driver can use native transport, such as epoll, io_uring etc. We wanted to help application builders and picking the right versions of the than required additional dependencies without having to search for them. But on the other hand, I think it's fair to assume quite technical users in that area that are aware that there's a bom for that. We also update our manual on that topic. Cheers.

See spring-projectsgh-47381 Signed-off-by: Gerrit Meier <[email protected]>

See spring-projectsgh-47381

snicoll

Tanks for the PR. I've started to polish in https://github.com/snicoll/spring-boot/tree/pr/47381

There's no need to push any further change. I've added a few comments and could use your insights when you have a min.

snicoll · 2025-10-03T14:05:54Z

...neo4j/src/main/java/org/springframework/boot/neo4j/autoconfigure/Neo4jAutoConfiguration.java

 	Driver neo4jDriver(Neo4jProperties properties, Environment environment, Neo4jConnectionDetails connectionDetails,
-			ObjectProvider<ConfigBuilderCustomizer> configBuilderCustomizers) {
+			ObjectProvider<ConfigBuilderCustomizer> configBuilderCustomizers,
+			ObjectProvider<ObservationRegistry> observationRegistryProvider) {


We can't do this here. If we did then we could not configure a Neo4j driver without the observation registry on the classpath.

snicoll · 2025-10-03T14:07:35Z

...neo4j/src/main/java/org/springframework/boot/neo4j/autoconfigure/Neo4jAutoConfiguration.java

 		builder.withMaxConnectionLifetime(pool.getMaxConnectionLifetime().toMillis(), TimeUnit.MILLISECONDS);
 		builder.withConnectionAcquisitionTimeout(pool.getConnectionAcquisitionTimeout().toMillis(),
 				TimeUnit.MILLISECONDS);
-		if (pool.isMetricsEnabled()) {


I am not sure I like that change. If metrics vs. no metrics is no longer needed, then I think the metricsEnabled flag should go away and have metrics to be exported if an ObservationRegistry is available. That's what the other components are doing at the moment.

Is there a reason to keep having a flag for this or was it just an attempt at migrating what we had before?

snicoll · 2025-10-03T14:09:38Z

...neo4j/src/main/java/org/springframework/boot/neo4j/autoconfigure/Neo4jAutoConfiguration.java

-			Scheme.validateScheme(lowerCaseScheme);
-		}
-		catch (IllegalArgumentException ex) {
+		if (!ServiceLoader.load(BoltConnectionProviderFactory.class)


That's quite a bit of ceremony here. Do we really need to invoke "any" factory this way? Also this adds an import on BoltConnectionProviderFactory...

snicoll · 2025-10-03T14:20:34Z

I've also switched this PR to an enhancement as it isn't "just" a dependency upgrade.

Upgrade Neo4j Java driver to 6.0.0.

75b0c12

Signed-off-by: Gerrit Meier <[email protected]>

spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 2, 2025

snicoll changed the title ~~Upgrade Neo4j Java driver to 6.0.0.~~ Upgrade to Neo4j Java Driver 6.0.0 Oct 2, 2025

Apply formatter

4aeb6eb

Signed-off-by: Gerrit Meier <[email protected]>

Fix style problems

02ee872

Signed-off-by: Gerrit Meier <[email protected]>

snicoll added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 3, 2025

snicoll added this to the 4.0.0-RC1 milestone Oct 3, 2025

snicoll self-assigned this Oct 3, 2025

snicoll pushed a commit to snicoll/spring-boot that referenced this pull request Oct 3, 2025

Upgrade to Neo4j Java Driver 6.0.0

628cbe5

See spring-projectsgh-47381 Signed-off-by: Gerrit Meier <[email protected]>

snicoll added a commit to snicoll/spring-boot that referenced this pull request Oct 3, 2025

Polish "Upgrade to Neo4j Java Driver 6.0.0"

d8e5fa6

See spring-projectsgh-47381

snicoll reviewed Oct 3, 2025

View reviewed changes

snicoll added the status: waiting-for-feedback We need additional information before we can continue label Oct 3, 2025

snicoll changed the title ~~Upgrade to Neo4j Java Driver 6.0.0~~ Update Neo4j support to require Neo4j Java Driver 6.0.0 Oct 3, 2025

snicoll added type: enhancement A general enhancement and removed type: dependency-upgrade A dependency upgrade labels Oct 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Neo4j support to require Neo4j Java Driver 6.0.0 #47381

Update Neo4j support to require Neo4j Java Driver 6.0.0 #47381

meistermeier commented Oct 2, 2025

Uh oh!

snicoll commented Oct 2, 2025

Uh oh!

meistermeier commented Oct 2, 2025

Uh oh!

michael-simons commented Oct 2, 2025

Uh oh!

meistermeier commented Oct 2, 2025

Uh oh!

snicoll commented Oct 2, 2025 •

edited

Loading

Uh oh!

snicoll commented Oct 2, 2025

Uh oh!

michael-simons commented Oct 2, 2025

Uh oh!

snicoll left a comment

Uh oh!

snicoll Oct 3, 2025

Uh oh!

snicoll Oct 3, 2025

Uh oh!

snicoll Oct 3, 2025

Uh oh!

snicoll commented Oct 3, 2025

Uh oh!

Uh oh!

Update Neo4j support to require Neo4j Java Driver 6.0.0 #47381

Are you sure you want to change the base?

Update Neo4j support to require Neo4j Java Driver 6.0.0 #47381

Conversation

meistermeier commented Oct 2, 2025

Uh oh!

snicoll commented Oct 2, 2025

Uh oh!

meistermeier commented Oct 2, 2025

Uh oh!

michael-simons commented Oct 2, 2025

Uh oh!

meistermeier commented Oct 2, 2025

Uh oh!

snicoll commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snicoll commented Oct 2, 2025

Uh oh!

michael-simons commented Oct 2, 2025

Uh oh!

snicoll left a comment

Choose a reason for hiding this comment

Uh oh!

snicoll Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

snicoll Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

snicoll Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

snicoll commented Oct 3, 2025

Uh oh!

Uh oh!

snicoll commented Oct 2, 2025 •

edited

Loading