Skip to content

Fix extra body update #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+11 −4
Open

Fix extra body update #4956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4633af
fix:Modified the ChatCompletionRequest object, where the field extraB…
819318216 Nov 17, 2025
da6fac4
fix:Modified the ChatCompletionRequest object, where the field extraB…
819318216 Nov 17, 2025
37a12ff
Merge remote-tracking branch 'origin/fix_extra_body_update' into fix_…
819318216 Nov 19, 2025
05896c3
fix:Modified the ChatCompletionRequest object, where the field extraB…
819318216 Nov 25, 2025
a385984
Merge branch 'spring-projects:main' into fix_extra_body_update
819318216 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/spring-ai-openai/src/main/java/org/springframework/ai/openai/api/OpenAiApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,7 +1160,7 @@ public record ChatCompletionRequest(// @formatter:off
@JsonProperty("verbosity") String verbosity,
@JsonProperty("prompt_cache_key") String promptCacheKey,
@JsonProperty("safety_identifier") String safetyIdentifier,
Map<String, Object> extraBody) {
@JsonProperty("extra_body") Map<String, Object> extraBody) {

/**
* Compact constructor that ensures extraBody is initialized as a mutable HashMap
Expand Down
13 changes: 10 additions & 3 deletions ...ing-ai-openai/src/test/java/org/springframework/ai/openai/ChatCompletionRequestTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package org.springframework.ai.openai;

import java.util.HashMap;
import java.util.List;
import java.util.Map;

Expand Down Expand Up @@ -76,9 +77,13 @@ void whenToolRuntimeOptionsThenMergeWithDefaults() {
@Test
void createRequestWithChatOptions() {
var client = OpenAiChatModel.builder()
.openAiApi(OpenAiApi.builder().apiKey("TEST").build())
.defaultOptions(OpenAiChatOptions.builder().model("DEFAULT_MODEL").temperature(66.6).build())
.build();
.openAiApi(OpenAiApi.builder().apiKey("TEST").build())
.defaultOptions(OpenAiChatOptions.builder()
.model("DEFAULT_MODEL")
.temperature(66.6)
.extraBody(Map.of("key1", "value1"))
.build())
.build();

var prompt = client.buildRequestPrompt(new Prompt("Test message content"));

Expand All @@ -90,6 +95,8 @@ void createRequestWithChatOptions() {
assertThat(request.model()).isEqualTo("DEFAULT_MODEL");
assertThat(request.temperature()).isEqualTo(66.6);

assertThat(request.extraBody().get("key1")).isEqualTo("value1");

request = client.createRequest(new Prompt("Test message content",
OpenAiChatOptions.builder().model("PROMPT_MODEL").temperature(99.9).build()), true);

Expand Down