Skip to content

added isDirectBildMobileSwitcher to cover mobileSwitcher at session start #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickyanalytics wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added isDirectBildMobileSwitcher to cover mobileSwitcher at session start #253

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5e1350
added isDirectBildMobileSwitcher to cover mobileSwithcer at start
Sep 30, 2024
fade540
single quotes
Sep 30, 2024
f404b16
fixed typo
Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion extensions/doPlugins/doPlugins_global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,14 @@ s._articleViewTypeObj = {

},

isDirectBildMobileSwitcher: function (referrer) {
const wwwhReferrer = s._utils.getReferrer(referrer);
Copy link
Contributor

@mehakraza mehakraza Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about what is wwwhReferrer?

Copy link
Contributor Author

@nickyanalytics nickyanalytics Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oha, no idea but I think it was not an eye test :-D

const sessionStart = s._utils.isSessionStart();

return ((wwwhReferrer.includes('www.bild.de') || wwwhReferrer.includes('www.sportbild.bild.de')) && sessionStart);

},

isValidURL: function (urlString) {
try {
new URL(urlString);
Expand Down Expand Up @@ -420,7 +428,7 @@ s._articleViewTypeObj = {
} else if (this.isWithoutReferrer() && this.isNavigated() && isArticle) {
pageViewEvent = 'event26,event202'; // Dark Social Marketing Channel only with session start
channel = '';
}else if (this.isDirect(referrer)) {
}else if (this.isDirect(referrer) || this.isDirectBildMobileSwitcher(referrer)) {
pageViewEvent = 'event207'; // no Referrer at Session Start
channel = 'Direct';
} else {
Expand Down