Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/toms cleanup branch #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tomhobson
Copy link

No description provided.

Copy link

@mikelear mikelear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go through properly but my initial worry is having a separate genesis file location , all you end up doing is keeping the fork and versions in line , and any issues with genessis.ssz (which is the only genesis beacon uses) is an output from the tolling using the genesis.json file anyway so i think it maybe doesn't want to be in the files under geth but they should be neutral , the issue then though is the files load in config (which i like to keep it tidy) won't work without symlinks

@mikelear
Copy link

it is nice to clean it up , but it should be temporary anyway though as i don't think we should run a bootnode we should run a geth node as a boot nod e(so different helm install , values.yaml as we have ) but i only wanted the bootnode to replicate my local setup and see why it wasn't working , i've changed my lcoal to use geth as abootnode , hyou just pass a nodekey to the geth node , but sitll this is valuable as it means we can switch and use this , but i think it almsot want to be another helm install to spin up when we want to debug a geth bootnode issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants