Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types #29

Closed
wants to merge 2 commits into from
Closed

Add types #29

wants to merge 2 commits into from

Conversation

rickdgeerling
Copy link

Addresses #28

@iliasmentz
Copy link

Hey, any chance for this to get merged?

@rickdgeerling
Copy link
Author

In the mean time, you can add the index.d.ts file in your own repo under types/mock-http-server

@pietro909
Copy link

I suggest pushing them to Definitely Typed in the meanwhile. It is also suggested in Effective Typescript to keep them separated so that we don't need to wait for the maintainers of a non-TS repo to act on type-related issues.

@rickdgeerling
Copy link
Author

@pietro909 Please be my guest if you've got the time. I'm short on time and I'm no longer using this library so there's little incentive for me to continue working on this.

@pietro909
Copy link

Sorry @tuxmachine saw now: I've found it faster to migrate to https://github.com/httptoolkit/mockttp which exposes a very similar interface and is written in TS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants