Skip to content

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Jun 5, 2025

No description provided.

@Vampire Vampire force-pushed the vampire/fix-retry-docs branch from 0fbb1a3 to ad388ae Compare June 5, 2025 09:38
Copy link
Member Author

Vampire commented Jun 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.93%. Comparing base (52ad7b1) to head (801f260).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2174      +/-   ##
============================================
+ Coverage     81.90%   81.93%   +0.03%     
- Complexity     4732     4734       +2     
============================================
  Files           463      463              
  Lines         14767    14767              
  Branches       1869     1869              
============================================
+ Hits          12095    12100       +5     
+ Misses         1981     1977       -4     
+ Partials        691      690       -1     
Files with missing lines Coverage Δ
spock-core/src/main/java/spock/lang/Retry.java 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vampire Vampire force-pushed the vampire/fix-retry-docs branch 2 times, most recently from 592f7a9 to a8dd99c Compare June 5, 2025 14:46
In addition, an optional `condition` closure can be used to determine if a feature should be retried.
It also provides special support for data driven features, offering to either retry all iterations or just the failing ones.
In its standard mode it only retries the feature method execution, but this can be changed using `mode` to
also run setup and cleanup on retries. Even in this mode, the retry is only triggered if the feature method is failing
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leonard84 is this actually the intended and expected behavior?
That only expected failures in the feature method trigger a retry I mean.
I do some UI tests using Geb with Marathon driver and it happens sometimes on GHA that the application cannot be started and thus the driver throws an exception.

This is done in an iteration interceptor before calling proceed, the iteration interceptor is within the retry iteration interceptor due to using global retry extension. But as the error happens there and not during feature method invocation, it does not cause a retry.

@Vampire Vampire force-pushed the vampire/fix-retry-docs branch from a8dd99c to e11ba73 Compare August 25, 2025 12:57
@Vampire Vampire force-pushed the vampire/fix-retry-docs branch from e11ba73 to 801f260 Compare October 9, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant