Fix SmallVector move constructor and move assignment for move-only types - #148
Open
jihaohaaaa wants to merge 1 commit into
Open
Fix SmallVector move constructor and move assignment for move-only types#148jihaohaaaa wants to merge 1 commit into
jihaohaaaa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When FASTGLTF_USE_CUSTOM_SMALLVECTOR is enabled, SmallVector(SmallVector&&) and SmallVector::operator=(SmallVector&&) previously invoked copy(), which uses copy assignment *result++ = *first. For types with deleted copy constructors/assignments (such as Primitive containing std::unique_ptr), this caused compilation errors when moving SmallVector. This PR introduces a move_elements helper function to perform std::move instead of copying.