Support to string digititization type #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since last year Megin has changed the head shape digitization (extra points) from point to string; however, MNE had been supporting only
FIFFT_DIG_POINT_STRUCTfor those. This leads to missing extra points if the data is recorded using new DACQ systems from MEGIN. Therefore, the support for the string typeFIFFT_DIG_STRING_STRUCTwas required.The issue was resolved early this year in MNE-Python and during summer in MNE-MATLAB (please see the passed test results and detailed conversation here: https://github.com/mne-tools/mne-matlab/pull/36/commits). Furthermore, it was updated into FieldTrip and BrainStorm; however, SPM12 is still missing this update.
Here, I made the required changes to the
fiff_read_meas_info.mandfiff_read_tag.mfiles to support reading the string-type digitization.Thanks.