Repository navigation
fix(site): make CI pass with the published talk deck - #85
Merged
Merged
Conversation
Lists the deck files in the Pages source contract, adds /talk/ to the expected sitemap, resolves directory links to index.html, and checks the deck only loads local assets and links back to the site. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #84, which merged before its test fix was pushed. Since then,
mainfails the Unit tests job on macOS and Ubuntu.tests/test_marketing_site.pyso the deck counts as published Pages content:/talk/in the sitemaptalk/toindex.htmlTalkDeckContractTests, which checks that the deck loads only local assets and links back to the site.docs/talk/index.htmlanddocs/talk/fonts/OFL-Tektur.txt. This was failing Static checks (git diff --check) on the original PR branch. The change is whitespace-only:git diff -wis empty.Test plan
python3 -m unittest discover -s tests: 1536 tests OK (17 skipped)git diff --check origin/main HEADis clean🤖 Generated with Claude Code