Fix compatibility with PHP 8.3.0 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The imagerotate() function used to take 3 parameters. Then, in PHP 5.1.0, an optional fourth parameter was added. And now, in PHP 8.3.0, that parameter has been removed. Since the code in GdAdapter always explicitly provides the fourth parameter when calling the function, this causes it to fail with an ArgumentCountError under PHP 8.3.0. This commit removes the unused fourth parameter from all call sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
imagerotate()function used to take 3 parameters. Then, in PHP 5.1.0, an optional fourth parameter was added. And now, in PHP 8.3.0, that parameter has been removed. Since the code inGdAdapteralways explicitly provides the fourth parameter when calling the function, this causes it to fail with anArgumentCountErrorunder PHP 8.3.0.This commit removes the unused fourth parameter from all call sites.