This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(retrofit1): exclude Retrofit2EncodeCorrectionInterceptor from the retrofit1 clients#4857
Merged
mergify[bot] merged 3 commits intospinnaker:masterfrom Apr 8, 2025
Conversation
kirangodishala
force-pushed
the
fix-retrofit1-with-encode-interceptor
branch
from
db79cf7 to
9fce8a1
Compare
… retrofit1 clients
…o retrofit1 clients in tests as kork is updated with new constructor
kirangodishala
force-pushed
the
fix-retrofit1-with-encode-interceptor
branch
from
272306f to
b11bbfe
Compare
dbyron-sf
approved these changes
Apr 8, 2025
Contributor
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Contributor
|
@Mergifyio backport release-1.37.x |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
added a commit
that referenced
this pull request
Apr 9, 2025
… retrofit1 clients (#4857) * fix(retrofit1): exclude Retrofit2EncodeCorrectionInterceptor from the retrofit1 clients * test(retrofit1): revert adding Retrofit2EncodeCorrectionInterceptor to retrofit1 clients in tests as kork is updated with new constructor --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 2fdb327)
mergify Bot
added a commit
that referenced
this pull request
Apr 9, 2025
… retrofit1 clients (#4857) (#4860) * fix(retrofit1): exclude Retrofit2EncodeCorrectionInterceptor from the retrofit1 clients * test(retrofit1): revert adding Retrofit2EncodeCorrectionInterceptor to retrofit1 clients in tests as kork is updated with new constructor --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 2fdb327) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, along with spinnaker/kork#1233, fixes any issues arising due to the addition of Retrofit2EncodeCorrectionInterceptor to the OkHttpClient that is used for retrofit1 client.