This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(saml): With the upgrade to spring saml off of the DSL signing saml requests were broken. This restores that functionality#1898
Merged
Conversation
…l requests were broken. This restores that capability
jvz
approved these changes
May 14, 2025
| Resource certificate = resourceLoader.getResource(certificateLocation); | ||
| try (InputStream inputStream = certificate.getInputStream()) { | ||
| return (X509Certificate) | ||
| CertificateFactory.getInstance("X.509").generateCertificate(inputStream); |
Contributor
There was a problem hiding this comment.
Isn't there utility code in kork-crypto for this?
Member
Author
There was a problem hiding this comment.
PROBABLY? - but this is a direct copy/paste from Spring Security so was just re-using all of that Autowiring flow. I'd like to replace all of this with the spring autowiring similar to the oauth2 autowiring changes I'm seeing. BUT this is a "fix" vs. a... larger rewrite of that auth flow.
Member
Author
|
@Mergifyio backport release-1.36.x release-1.37.x |
Contributor
✅ Backports have been createdDetails
|
Member
Author
|
@Mergifyio backport release-1.38.x |
Contributor
✅ Backports have been createdDetails
|
This was referenced May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.