Skip to content
This repository was archived by the owner on Dec 20, 2025. It is now read-only.

fix(saml): Set allowedAccounts info#1856

Closed
jmartinezfl wants to merge 4 commits into
spinnaker:masterfrom
jmartinezfl:fix/set-allowedaccounts-info-for-saml-users
Closed

fix(saml): Set allowedAccounts info#1856
jmartinezfl wants to merge 4 commits into
spinnaker:masterfrom
jmartinezfl:fix/set-allowedaccounts-info-for-saml-users

Conversation

@jmartinezfl
Copy link
Copy Markdown

@jmartinezfl jmartinezfl commented Dec 3, 2024

With the changes introduced in #1744, the information related to the accounts the user has access to, is no longer available when authentication is performed using SAML. As a result, the allowedAccounts field appears as an empty list in the execution context.

With this fix, the information is set again, ensuring that the allowedAccounts parameter is correctly populated in the execution context when using SAML authentication.

@dbyron-sf
Copy link
Copy Markdown
Contributor

@jmartinezfl please run $ ./gradlew spotlessApply, and add a test that fails without this fix.

@jasonmcintosh
Copy link
Copy Markdown
Member

FYI: I THINK this is not needed. "allowedAccounts" would add http headers "X-SPINNAKER-ACCOUNTS" field. However, none of the internal services AT THIS POINT looks like they use this header anymore. As such, this shouldn't be needed. Will close this but if permissions ARE broken, please let us know we can open in github.com/spinnaker/spinnaker a new issue with this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants