Skip to content
This repository was archived by the owner on Dec 20, 2025. It is now read-only.

fix(deck): Fix RunJob external logs when component is not mounted and interpolation is needed #10188

Closed
christosarvanitis wants to merge 1 commit into from
Closed

fix(deck): Fix RunJob external logs when component is not mounted and interpolation is needed #10188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/manifest/stage/JobStageExecutionLogs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { template } from 'lodash';
import { isEmpty, template } from 'lodash';
import React from 'react';
import { from as observableFrom, Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators';
Expand Down Expand Up @@ -52,7 +52,7 @@ export class JobStageExecutionLogs extends React.Component<IJobStageExecutionLog
const { manifest } = this.state;
const { externalLink, podNamesProviders, location, account } = this.props;
// prefer links to external logging platforms
if (externalLink) {
if (externalLink && (!externalLink.includes('{{') || !isEmpty(manifest))) {
Copy link
Copy Markdown
Member

@jasonmcintosh jasonmcintosh Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a rewrite or rethink on this... too complicated of logic. I could see passing all of this down a bit and being a bit smarter on the checks internally.

ALSO ideally would have a test on these... spec test that checks the render logic maybe

return (
<a target="_blank" href={this.renderExternalLink(externalLink, manifest)}>
Console Output (External)
Expand Down
Loading