ref(templates/go): use spinframework import path #3116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Reese <[email protected]>
|
Right after opening this, I'm thinking we may want to cut a release of the SDK in it's new home first. |
vdice
reviewed
Apr 17, 2025
There was a problem hiding this comment.
I forgot about this Makefile. Just a note that I don't think it is being invoked anymore, now that the go and rust SDKs live in their own repo. We can remove - unless you're finding it useful for bumps like these.
I think it would be nice to pin to a known release. I wasn't sure what the release strategy in the upstream go SDK is, what with the push to support wasip2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no tagged releases for the new Go SDK. This pins the SDK in the templates to a git sha.