-
-
Notifications
You must be signed in to change notification settings - Fork 233
feat(snippets): new snippet (dancing-minion) #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ncing minion which moves along with the progress bar.
WalkthroughAdds a new "Dancing Minion" snippet to resources/snippets.json, modeled after existing progress-bar creature snippets. It defines image URL, preview path, dimensions (60px), z-index, and transform/positioning (left and animation transforms). No changes to exports or public APIs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
resources/snippets.json (1)
525-528
: Make the overlay non-blocking and tighten CSS.The ::before element can intercept pointer events on the slider. Also,
calc(40%)
is redundant andbackground-repeat
should be explicit.Apply:
- "code": ".player-controls .playback-progressbar .progress-bar::before { z-index:1; content: ''; width: 60px; height: 60px; bottom: calc(40%); left: var(--progress-bar-transform); position: absolute; transition: left var(--progress-bar-duration); transform: translate(-25px, 13px); image-rendering: auto; background-size: 60px 60px; background-image: url('https://media.tenor.com/gvjH24AtYM0AAAAi/minion-minions.gif'); }", + "code": ".player-controls .playback-progressbar .progress-bar::before { z-index:1; content: ''; width: 60px; height: 60px; bottom: 40%; left: var(--progress-bar-transform); position: absolute; transition: left var(--progress-bar-duration); transform: translate(-25px, 13px); pointer-events: none; image-rendering: auto; background-size: 60px 60px; background-repeat: no-repeat; background-image: url('https://media.tenor.com/gvjH24AtYM0AAAAi/minion-minions.gif'); }",Optional: if it renders under the bar in some themes, bump
z-index
slightly (e.g., 2–3).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
resources/assets/snippets/dancing-minion-snippet.gif
is excluded by!**/*.gif
📒 Files selected for processing (1)
resources/snippets.json
(1 hunks)
🔇 Additional comments (1)
resources/snippets.json (1)
528-529
: Resolve preview asset — no further action needed.
Added a Dancing Minion snippet which shows a dancing minion which moves along with the progress bar.
Summary by CodeRabbit