imgmath: Avoid parallel workers depth write race #13457
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschueller
force-pushed
the
depth
branch
6 times, most recently
from
72b29dd to
fe3ea1f
Compare
jschueller
force-pushed
the
depth
branch
3 times, most recently
from
39a111d to
ffb1fd7
Compare
|
Can we do this without a new dependency? |
|
I tried to avoid that by writing the depth to a separate file, but I just circled backed to the same kind of race issue, unless you have other ideas ? else there is os.lockf but that's unix-only. Maybe it can become optional, ie try to load it else continue. |
jschueller
force-pushed
the
depth
branch
7 times, most recently
from
bbfd65f to
61c0105
Compare
|
@AA-Turner I made the filelock module optional, what do you think ? |
jschueller
force-pushed
the
depth
branch
2 times, most recently
from
1468ce9 to
f1062c9
Compare
Ensure parallel workers do not try to write the image depth multiple times to achieve reproducible builds. Typically my svg files ended up like this: ``` ... <!-- DEPTH=0 --> <!-- DEPTH=0 --> ``` So images were not the same and sometimes the depth was incorrect too. Introduces a new dependency to the filelock module.
Instead of mandatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure parallel workers do not try to write the image depth multiple times to achieve reproducible builds without -j1.
Typically some of my svg files randomly ended up like this:
So images were not the same and sometimes the depth was incorrect too.
Introduces a new dependency to the filelock module though.
My project openturns has a pretty big doc with ~8k math formulas and I didnt notice any slowdown with this (-j8).