Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelock Recovery Extension #9589

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Timelock Recovery Extension tests

9be9aa9
Select commit
Loading
Failed to load commit list.
Open

Timelock Recovery Extension #9589

Timelock Recovery Extension tests
9be9aa9
Select commit
Loading
Failed to load commit list.
Cirrus CI / unittests: Tox Python 3 debug mode failed Mar 5, 2025 in 18m 45s

Task Summary

Instruction tox failed in 18:01

Details

✅ 00:16 clone
✅ 00:02 pip
✅ 00:01 version
✅ 00:01 tag
✅ 00:18 install
✅ 00:01 libsecp_build
❌ 18:01 tox

tests/test_timelock_recovery.py:84: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
electrum/plugins/timelock_recovery/timelock_recovery.py:89: in make_unsigned_alert_tx
    return self.wallet.make_unsigned_transaction(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

args = (<electrum.wallet.Standard_Wallet object at 0x7f915e3ed920>,)
kw_args = {'coins': [<electrum.transaction.PartialTxInput object at 0x7f915e3edbe0>, <electrum.transaction.PartialTxInput object...put script=00145c625b4077ebe74eebee083fef1f23b6d5e55cc8 address=tb1qt339ksrha0n5a6lwpql778erkm272hxgamdc0u value=600>]}
name = 'Abstract_Wallet.make_unsigned_transaction', t0 = 1741216468.51351

    def do_profile(*args, **kw_args):
        name = func.__qualname__
        t0 = time.time()
>       o = func(*args, **kw_args)
E       TypeError: Abstract_Wallet.make_unsigned_transaction() got an unexpected keyword argument 'fee'

electrum/util.py:492: TypeError
----------------------------- Captured stderr call -----------------------------
568.62 | I | simple_config.SimpleConfig | electrum directory /tmp/tmp8dnlac80
568.63 | I | storage.WalletStorage | wallet path /tmp/tmp8dnlac80/timelock_recovery_wallet
568.63 | I | wallet_db.WalletDBUpgrader | upgrading wallet format
568.63 | D | util.profiler | WalletDBUpgrader.upgrade 0.0045 sec
568.66 | D | util.profiler | WalletDB.load_transactions 0.0003 sec
568.66 | D | util.profiler | AddressSynchronizer.load_local_history 0.0006 sec
568.67 | D | util.profiler | AddressSynchronizer.check_history 0.0008 sec
570.13 | I | lnworker.LNWallet.[timelock_recovery_wallet] | set_invoice_status 720848b95f41736e6bdc838f4587e6205c417702353f3fd7d9b6b1ceb632e65b: 4
570.15 | W | asyncio | Executing <Task finished name='Task-347210' coro=<TestTimelockRecovery.test_make_unsigned_recovery_tx() done, defined at /tmp/cirrus-ci-build/tests/test_timelock_recovery.py:77> exception=TypeError("Abstract_Wallet.make_unsigned_transaction() got an unexpected keyword argument 'fee'") created at /usr/local/lib/python3.13/asyncio/runners.py:100> took 1.519 seconds
571.88 | W | asyncio | Executing <Handle run_coroutine_threadsafe.<locals>.callback() at /usr/local/lib/python3.13/asyncio/tasks.py:993 created at /usr/local/lib/python3.13/asyncio/tasks.py:1003> took 0.556 seconds
576.31 | W | asyncio | Executing <Handle run_coroutine_threadsafe.<locals>.callback() at /usr/local/lib/python3.13/asyncio/tasks.py:993 created at /usr/local/lib/python3.13/asyncio/tasks.py:1003> took 0.851 seconds
------------------------------ Captured log call -------------------------------
INFO     electrum.simple_config.SimpleConfig:simple_config.py:253 electrum directory /tmp/tmp8dnlac80
INFO     electrum.storage.WalletStorage:storage.py:71 wallet path /tmp/tmp8dnlac80/timelock_recovery_wallet
INFO     electrum.wallet_db.WalletDBUpgrader:wallet_db.py:186 upgrading wallet format
DEBUG    electrum.util.profiler:util.py:495 WalletDBUpgrader.upgrade 0.0045 sec
DEBUG    electrum.util.profiler:util.py:495 WalletDB.load_transactions 0.0003 sec
DEBUG    electrum.util.profiler:util.py:495 AddressSynchronizer.load_local_history 0.0006 sec
DEBUG    electrum.util.profiler:util.py:495 AddressSynchronizer.check_history 0.0008 sec
INFO     electrum.lnworker.LNWallet.[timelock_recovery_wallet]:lnworker.py:2429 set_invoice_status 720848b95f41736e6bdc838f4587e6205c417702353f3fd7d9b6b1ceb632e65b: 4
WARNING  asyncio:base_events.py:2035 Executing <Task finished name='Task-347210' coro=<TestTimelockRecovery.test_make_unsigned_recovery_tx() done, defined at /tmp/cirrus-ci-build/tests/test_timelock_recovery.py:77> exception=TypeError("Abstract_Wallet.make_unsigned_transaction() got an unexpected keyword argument 'fee'") created at /usr/local/lib/python3.13/asyncio/runners.py:100> took 1.519 seconds
WARNING  asyncio:base_events.py:2035 Executing <Handle run_coroutine_threadsafe.<locals>.callback() at /usr/local/lib/python3.13/asyncio/tasks.py:993 created at /usr/local/lib/python3.13/asyncio/tasks.py:1003> took 0.556 seconds
WARNING  asyncio:base_events.py:2035 Executing <Handle run_coroutine_threadsafe.<locals>.callback() at /usr/local/lib/python3.13/asyncio/tasks.py:993 created at /usr/local/lib/python3.13/asyncio/tasks.py:1003> took 0.851 seconds
=============================== warnings summary ===============================
.tox/py3/lib/python3.13/site-packages/google/protobuf/internal/well_known_types.py:91
  /tmp/cirrus-ci-build/.tox/py3/lib/python3.13/site-packages/google/protobuf/internal/well_known_types.py:91: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    _EPOCH_DATETIME_NAIVE = datetime.datetime.utcfromtimestamp(0)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_timelock_recovery.py::TestTimelockRecovery::test_make_unsigned_alert_tx
FAILED tests/test_timelock_recovery.py::TestTimelockRecovery::test_make_unsigned_cancellation_tx
FAILED tests/test_timelock_recovery.py::TestTimelockRecovery::test_make_unsigned_recovery_tx
======= 3 failed, 769 passed, 5 skipped, 1 warning in 1047.88s (0:17:27) =======
py3: exit 1 (1049.86 seconds) /tmp/cirrus-ci-build> coverage run --source=electrum '--omit=electrum/gui/*,electrum/plugins/*,electrum/scripts/*' -m pytest tests -v pid=774
  py3: FAIL code 1 (1080.78=setup[30.92]+cmd[1049.86] seconds)
  evaluation failed :( (1080.95 seconds)