Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JIT zeroconf channel opening #9584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

f321x
Copy link
Member

@f321x f321x commented Feb 27, 2025

Related PRs:

Changes:

  • make it possible to have multiple JIT channels with single LSP by using the deterministic remote scid alias created on channel open instead of the static node id hash as scid alias of the jit channel on LSP side
  • add error handling to correctly wind down and remove channels and local txs if the jit opening failed (e.g. if lsp didn't get preimage from client)
  • disable JIT/zeroconf on LSP side if exceptions occur to prevent further issues
  • only finalize jit opening if funding tx got successfully accepted to our mempool
  • add funding tx fee to opening fee of channel so client pays for (funding) mining fees
  • use max(absolute fee, relative fee) instead of failing zeroconf opening if fee is below min abs fee
  • add checks to LSP and client side to prevent insane fees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant