Skip to content

[DRAFT] Redesign/datasets ICA addition #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Apr 1, 2025
Merged

[DRAFT] Redesign/datasets ICA addition #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
66faeaa
initial test for ica dynamic item inclusion
vmcru Mar 4, 2025
4b62e60
exposed method for ica, used mne BIDSPath, path needs checking for pr…
vmcru Mar 5, 2025
c3ec3dc
Apply suggestions from code review
bruAristimunha Mar 5, 2025
77a8c59
Apply suggestions from code review
bruAristimunha Mar 5, 2025
a222c7c
Merge branch 'redesign/datasets' into redesign/datasets
vmcru Mar 7, 2025
3a78e1d
modifications to ica and validate to pass merge
vmcru Mar 7, 2025
86af6be
removed unused imports from all files and added credits
vmcru Mar 7, 2025
f29636c
updated validate_ica.py
vmcru Mar 7, 2025
30ff4be
Apply suggestions from code review
bruAristimunha Mar 18, 2025
f3330d9
support for ica as process added.
vmcru Mar 23, 2025
4e8bb55
Added hashing, setting check, and fixed caching bug.
vmcru Mar 23, 2025
b592c60
precommit mods
vmcru Mar 23, 2025
e2973aa
formatting fix
vmcru Mar 23, 2025
3f8b646
optional filtering added
vmcru Mar 23, 2025
73d1e93
added hashing to description name.
vmcru Mar 23, 2025
ade6b8d
added python-picard dependency in extra-requirements.txt for ica pica…
vmcru Mar 23, 2025
8b6633e
format fix extra-requirements.txt
vmcru Mar 23, 2025
a1031d2
Update benchmarks/MOABB/dataio/ica.py
vmcru Mar 25, 2025
282c016
Update benchmarks/MOABB/dataio/ica.py
vmcru Mar 25, 2025
ad2e39d
Update benchmarks/MOABB/dataio/datasets.py
vmcru Mar 26, 2025
822dc46
renamic critical to base and removing unnecessary comments
vmcru Mar 26, 2025
c524d11
tests upgrading pytest to see if it fixes breaks
vmcru Mar 26, 2025
a6fb933
added docstrings to process andn dynamic items functions.
vmcru Mar 26, 2025
544e638
formatting fixes
vmcru Mar 26, 2025
77daeeb
docstring fix
vmcru Mar 26, 2025
84e09dc
docstring adaptations for validate_ica.py
vmcru Mar 26, 2025
96e2546
precommit fixes
vmcru Mar 26, 2025
87ef955
Merge branch 'develop-eeg' into redesign/datasets
vmcru Mar 28, 2025
6e22fe5
rework of the metadata checking and storing
vmcru Mar 28, 2025
ab42aa9
metadata changes
vmcru Mar 28, 2025
2652128
precommit fixes
vmcru Mar 28, 2025
f2263e4
updates to the test files and minor tqeat to ica parameters.
vmcru Mar 28, 2025
210dd9e
adapted hashing for consistency and reproducibility. removed optional…
vmcru Mar 28, 2025
d787c0b
shpeechbrain changes.
vmcru Mar 28, 2025
4b03501
removed validate_ica.py from tracked files
vmcru Mar 28, 2025
06f873a
changed folder from derivaties to processor
vmcru Apr 1, 2025
ead65b3
precommit action error fix
vmcru Apr 1, 2025
82cdd90
precommit action error fix 2
vmcru Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: actions/checkout@v4.2.2
- uses: actions/setup-python@v5.5.0
with:
python-version: '3.8'
- uses: pre-commit/action@v2.0.3
python-version: '3.11'
- uses: pre-commit/action@v3.0.1
Loading