[fix] 깃 레포 delete 매핑 및 이메일 등록 오류 수정 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yereumi
approved these changes
May 16, 2025
|
|
||
| if (Objects.nonNull(email)) { | ||
| String trimmed = email.trim(); | ||
| if (!trimmed.isEmpty() && !EMAIL_PATTERN.matcher(trimmed).matches()) { |
Collaborator
There was a problem hiding this comment.
만약에 이메일 패턴은 통과했는데 해당 이메일이 존재하지 않으면 어디서 에러를 잡는지 궁금합니다~
Member
Author
There was a problem hiding this comment.
현재 코드에서 EMAIL_PATTERN은 문자열이 이메일 형식에 맞는지만 검증합니다. 즉, 정규식 검증을 통과한다고 해서 실제 존재하는 이메일이라는 보장은 없습니다.
그래서 SMTP ping 또는 인증 메일 전송 등으로 유효성을 확인해야 합니다.
SMTP 핑은 DNS 조회로 메일 서버 존재 확인 후 RCPT TO 명령으로 존재 여부를 탐색하지만 대부분 메일 서버가 거부하고
가장확실한 방법은 인증 메일 전송으로 유효성을 체크하는 것인데 아직 구현하지 않았습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 개요
✨ 기타 참고 사항
🔗 관련 이슈